Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c

From: Sergei Shtylyov
Date: Mon Jan 19 2009 - 13:02:09 EST


Hello.

Alan Cox wrote:

[ I'm also not happy with the naming but couldn't think of a better one. ]

Legacy perhaps?

Legacy to most people means either ISA/VLB or the PCI legacy
compatibility mode so that would be confusing.

That's what this code is for (minus the MMIO accessors perhaps).

BTW if you moved to ioreadX you could get rid of almost all the readb/inb
special casing.

And burden the driver code with function calls ISO in/out instructions, at least on x86. It's somewhat arguable move.

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/