Re: [PATCH] x86: Remove never-called arch_setup_msi_irq()

From: H. Peter Anvin
Date: Mon Jan 19 2009 - 01:18:14 EST


Michael Ellerman wrote:
> Since commit 75c46fa, "x64, x2apic/intr-remap: MSI and MSI-X
> support for interrupt remapping infrastructure", x86 has had an
> implementation of arch_setup_msi_irqs().
>
> That implementation does not call arch_setup_msi_irq(), instead it calls
> setup_irq(). No other x86 code calls arch_setup_msi_irq().
>
> That leaves only arch_setup_msi_irqs() in drivers/pci/msi.c, but that
> routine is overridden by the x86 version of arch_setup_msi_irqs().
>
> So arch_setup_msi_irq() is dead code, remove it.

Applied to tip:x86/cleanups, thanks!

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/