Re: [GIT PULL -tip] fix 41 'make headers_check' warnings

[Stephen Rothwell]

Hi Jaswinder,

On Mon, 19 Jan 2009 08:01:14 +0530 Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:
>
> On Mon, 2009-01-19 at 10:53 +1100, Stephen Rothwell wrote:
> > 
> > On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:
> > >
> > > diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
> > > index 04b4d73..277de8c 100644
> > > --- a/include/linux/pktcdvd.h
> > > +++ b/include/linux/pktcdvd.h
> > > @@ -33,11 +33,15 @@
> > >   * able to sucessfully recover with this option (drive will return good
> > >   * status as soon as the cdb is validated).
> > >   */
> > > +#ifdef __KERNEL__
> > >  #if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
> > >  #define USE_WCACHING		1
> > >  #else
> > >  #define USE_WCACHING		0
> > >  #endif
> > > +#else /* __KERNEL__ */
> > > +#define USE_WCACHING		0
> > > +#endif /* __KERNEL__ */
> > 
> > This also only has one user (drivers/block/pktcdvd.c) so maybe it should
> > be moved there.
> > 
> 
> Already fixed in v3 as pointed by Ingo.

I was actually suggesting that you move the whole 

#if defined(CONFIG_CDROM_PKTCDVD_WCACHE)
#define USE_WCACHING		1
#else
#define USE_WCACHING		0
#endif

into drivers/block/pktcdvd.c as that is the only place USE_WCACHING is
used.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature