Re: [GIT PULL -tip] fix 41 'make headers_check' warnings

From: Stephen Rothwell
Date: Sun Jan 18 2009 - 19:00:28 EST


Hi Jaswinder,

On Sun, 18 Jan 2009 15:40:54 +0530 Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx> wrote:
>
>
> /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/pkt_cls.h:306: leaks CONFIG_NET to userspace where it is not valid
> /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/pkt_cls.h:307: leaks CONFIG_NET to userspace where it is not valid

> diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h
> index 3c842ed..7a45e09 100644
> --- a/include/linux/pkt_cls.h
> +++ b/include/linux/pkt_cls.h
> @@ -304,8 +304,8 @@ enum
> TCA_FW_UNSPEC,
> TCA_FW_CLASSID,
> TCA_FW_POLICE,
> - TCA_FW_INDEV, /* used by CONFIG_NET_CLS_IND */
> - TCA_FW_ACT, /* used by CONFIG_NET_CLS_ACT */
> + TCA_FW_INDEV, /* used by NET_CLS_IND */
> + TCA_FW_ACT, /* used by NET_CLS_ACT */
> TCA_FW_MASK,

Again, surely we can improve the tool to not warn about these. If nothing
else, the actual warning is not correct.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature