Re: [PATCH 03/17] x86-64: Convert irqstacks to per-cpu

[Brian Gerst]

On Sat, Jan 17, 2009 at 11:58 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> Brian Gerst wrote:
>> @@ -211,15 +211,13 @@ ENTRY(secondary_startup_64)
>>        * data area.  Computing this requires two symbols - __per_cpu_load
>>        * and per_cpu__gdt_page.  As linker can't do no such relocation, do
>>        * it by hand.  As early_gdt_descr is manipulated by C code for
>> -      * secondary CPUs, this should be done only once for the boot CPU
>> -      * when early_gdt_descr_base contains zero.
>> +      * secondary CPUs, this should be done only once for the boot CPU.
>>        */
>
> It would probably be nice to mention that it's calculating per cpu
> load addresses for early access.  The comment only refers to gdt_page
> which is a bit misleading as it now also adjusts irqstackptr.
>
> Also, as pda field name, irqstackptr might be fine but wouldn't it be
> better to rename it to at least irq_stack_ptr as this change requires
> touching every users anyway?

I kept the same name unless it would conflict with something.  If you
want to rename it, it should be a separate patch.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/