Re: [PATCH] platform/x86: eeepc-laptop uses INPUT

[Ingo Molnar]

* Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:

> eeepc-laptop uses the input layer, so needs to depend on it.
> 
> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
> 
> ---
> 
> Ugh. The drivers in here seem to use a mixture of select and depends - 
> I've just followed what was already being used, but have no idea what 
> the convention really is here.
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e65448e..d4908e0 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -281,6 +281,7 @@ config EEEPC_LAPTOP
>  	select BACKLIGHT_CLASS_DEVICE
>  	select HWMON
>  	select RFKILL
> +	select INPUT

hm, that looks wrong - selecting an interactive option like CONFIG_INPUT 
is a bad idea and can lead to further dependency problems. depends-on 
might be better. (any distro kernel will have INPUT enabled anyway, so 
this is not a reduction in utility)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/