Re: [PATCH] leds: Fix bounds checking of wm8350->pmic.led

From: Liam Girdwood
Date: Sat Jan 17 2009 - 11:21:08 EST


On Sat, 2009-01-17 at 16:06 +0100, Roel Kluin wrote:
> Fix bounds checking of wm8350->pmic.led
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c
> index 7aa3524..5056e23 100644
> --- a/drivers/regulator/wm8350-regulator.c
> +++ b/drivers/regulator/wm8350-regulator.c
> @@ -1435,7 +1435,7 @@ int wm8350_register_led(struct wm8350 *wm8350, int lednum, int dcdc, int isink,
> struct platform_device *pdev;
> int ret;
>
> - if (lednum > ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
> + if (lednum >= ARRAY_SIZE(wm8350->pmic.led) || lednum < 0) {
> dev_err(wm8350->dev, "Invalid LED index %d\n", lednum);
> return -ENODEV;
> }
> --

Applied.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/