Re: [GIT PATCH] firs round of SCSI bug fixes for 2.6.29-rc1

From: James Bottomley
Date: Fri Jan 16 2009 - 15:15:27 EST


On Fri, 2009-01-16 at 12:09 -0800, Grant Grundler wrote:
> On Fri, Jan 16, 2009 at 11:10 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> ...
> >>
> >> TBH, I still wouldn't implement it the way LSI maintainers did.
> >> I'm happy they are the maintainers and it's their call.
> >
> > They are doing things which effect the entire system, not just
> > their driver. So this doesn't fall under "maintainer's rights"
>
> Agreed. This case is about a debug option which is normally disabled.
> So most people will never see this.
>
> The thread was more about how to make the failure visible in a
> sane way WITHOUT the debug flag enabled. Then when the
> debug flag is enabled, panic the machine as well.
>
> > If they fail locally, that's fine and perfectly expected, but to take
> > the whole machine out is another matter altogether.
>
> Agreed.

Me too, but I rejected half of the LSI update because of other problems.
Since this is isolated to actual firmware debugging, which no normal
user will see, I let it go after a bit of arguing.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/