Re: [PATCH] x86: fully honor "nolapic" (take 2)

[Jan Beulich]

>>> Ingo Molnar <mingo@xxxxxxx> 16.01.09 13:45 >>>
>
>* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:
>
>> +	if (disable_apic) {
>> +#ifdef CONFIG_X86_IO_APIC
>> +		disable_ioapic_setup();
>> +#endif
>> +		return;
>> +	}
>
>Shouldnt that #ifdef be avoided by always providing the function - just it 
>is a NOP inline in the !CONFIG_X86_IO_APIC case?

That would make for a much bigger patch, since the io_apic.h doesn't
(and imo shouldn't) be included without that config option.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/