Re: [PATCH] x86: avoid early crash in disable_local_APIC()

[Ingo Molnar]

* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> >>> Ingo Molnar <mingo@xxxxxxx> 15.01.09 23:47 >>>
> >
> >* Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> >> hm, this gives a build failure on latest -tip:
> >> 
> >> arch/x86/kernel/apic.c: In function 'setup_local_APIC':
> >> arch/x86/kernel/apic.c:1135: error: implicit declaration of function 'disable_ioapic_setup'
> 
> Is this with a config that has X86_IO_APIC off (i.e. one the practical 
> use of which I never understood, and hence easily forget to consider)? 
> Otherwise I can't see how that could happen.

yeah. Such build failures are reminders to define such functions in a 
.config-invariant way: i.e. an extern prototype plus an inline NOP-wrapper 
for the !IO_APIC case.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/