Re: [PATCH 01/10] omap mailbox: cleanup omap2 register definitionwith macro

From: Hiroshi DOYU
Date: Fri Jan 16 2009 - 07:15:56 EST


From: "ext roel kluin" <roel.kluin@xxxxxxxxx>
Subject: Re: [PATCH 01/10] omap mailbox: cleanup omap2 register definition with macro
Date: Fri, 16 Jan 2009 10:56:01 +0100

[...]
> > +#define MAILBOX_SYSCONFIG 0x010
> > +#define MAILBOX_SYSSTATUS 0x014
> > +#define MAILBOX_MESSAGE(m) (0x040 + 4 * (m))
> > +#define MAILBOX_FIFOSTATUS(m) (0x080 + 4 * (m))
> > +#define MAILBOX_MSGSTATUS(m) (0x0c0 + 4 * (m))
> > +#define MAILBOX_IRQSTATUS(u) (0x100 + 8 * (u))
> > +#define MAILBOX_IRQENABLE(u) (0x108 + 8 * (u))
> ^^^^^^^
> shouldn't this be
> #define MAILBOX_IRQENABLE(u) (0x104 + 8 * (u))

Right. I'll fix, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/