Re: [patch 42/94] [PATCH 11/44] [CVE-2009-0029] System call wrappers part 01

From: Pavel Machek
Date: Fri Jan 16 2009 - 06:00:41 EST



> 2.6.28-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> commit 58fd3aa288939d3097fa04505b25c2f5e6e144d1 upstream.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

That does not make review exactly easy. Would it be possible to
inline upstream comment in the commit message?

...upstream commit message is empty :-(.

> -asmlinkage long
> -sys_nanosleep(struct timespec __user *rqtp, struct timespec __user *rmtp)
> +SYSCALL_DEFINE2(nanosleep, struct timespec __user *, rqtp,
> + struct timespec __user *, rmtp)
> {
> struct timespec tu;
>

Is it strictly neccessary to modify all the syscalls?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/