Re: [BUILD_FAILURE] next-20090115 - s390x - mm/kmemleak.c

From: Catalin Marinas
Date: Thu Jan 15 2009 - 07:15:18 EST


On Thu, 2009-01-15 at 14:08 +0200, Pekka Enberg wrote:
> On Thu, 2009-01-15 at 11:55 +0000, Catalin Marinas wrote:
> > On Thu, 2009-01-15 at 12:20 +0100, Heiko Carstens wrote:
> > > On Thu, Jan 15, 2009 at 04:05:04PM +0530, Kamalesh Babulal wrote:
> > > > Hi Stephen,
> > > >
> > > > next-20090115 allyesconfig build fails on s390x
> > > >
> > > > mm/built-in.o: In function `kmemleak_scan':
> > > > mm/kmemleak.c:977: undefined reference to `_sdata'
> > > > make: *** [.tmp_vmlinux1] Error 1
> > >
> > > A lot of architectures don't have _sdata definined in their linker scripts.
> > > On s390 _sdata would be the same as _etext. But that is not necessarily true
> > > for all architectures.
> >
> > Kmemleak has only been tested on ARM and x86. I can add patches for the
> > other architectures so that the compilation is fine but can't really run
> > such kernels.
>
> Yeah, but you could just depend on X86 || ARM in Kconfig, no?

Even better :-), I'll update the patches. Thanks.

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/