Re: [PATCH 2/2] ext2: Add blk_issue_flush() to syncing paths

[Theodore Tso]

On Wed, Jan 14, 2009 at 10:18:34AM -0800, Andrew Morton wrote:
> /**
>  * blkdev_issue_flush - queue a flush
>  * @bdev:	blockdev to issue flush for
>  * @error_sector:	error sector
>  *
>  * Description:
>  *    Issue a flush for the block device in question. Caller can supply
>  *    room for storing the error offset in case of a flush error, if they
>  *    wish to.  Caller must run wait_for_completion() on its own.
>  */
> 
> So afaict the change you've made is incomplete.  We'll queue a
> writeback command to the disk but we won't wait for it to be sent down
> the wire.  

No, that last part of the comment is stale, and it's already been
confirmed by Jens.   He's queued in the block tree: