Re: [PATCH] module: kzalloc mod->ref

From: Takashi Iwai
Date: Wed Jan 14 2009 - 15:37:32 EST


At Wed, 14 Jan 2009 14:29:08 -0500,
Valdis.Kletnieks@xxxxxx wrote:
>
> On Wed, 14 Jan 2009 17:25:31 +0100, Takashi Iwai said:
>
> > We can use nr_cpu_ids instead of NR_CPUS.
> > For a machine like 4096 CPUs, such an amount of memory is like a
> > peanut :)
>
> It's not peanuts if you're dealing with a distro kernel that's essentially
> forced to compile with NR_CPUS=<some moby integer>, but booting on a single or
> dual core system with possibly not even 1G of memory.

My suggestion above is to use nr_cpu_ids, which is the actual number
of CPUs, not a constant like NR_CPUS.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/