Re: [PATCH] lib/idr.c: Zero memory properly in idr_remove_all

[Andrew Morton]

On Wed, 14 Jan 2009 09:59:07 +0100 Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:

> > --- a/lib/idr.c~lib-idrc-use-kmem_cache_zalloc-for-the-idr_layer-cache
> > +++ a/lib/idr.c
> > @@ -121,7 +121,7 @@ int idr_pre_get(struct idr *idp, gfp_t g
> >  {
> >  	while (idp->id_free_cnt < IDR_FREE_MAX) {
> >  		struct idr_layer *new;
> > -		new = kmem_cache_alloc(idr_layer_cache, gfp_mask);
> > +		new = kmem_cache_zalloc(idr_layer_cache, gfp_mask);
> >  		if (new == NULL)
> >  			return (0);
> >  		move_to_free_list(idp, new);
> ...
> 
> I wonder if it would be more robust --- or even necessary --- to instead
> add proper initialization code to get_from_free_list().
> 
> As far as David and I tested the new idr using code in firewire, we
> called idr_remove_all() *and* idr_destroy() before any subsequent
> idr_get_new().  But in practice, idr_get_new() may of course also happen
> between idr_remove_all() and idr_destroy().
> 
> And then this fix won't be sufficient, would it?

Maybe I'm having a thick day, but I'm not following you at all here.

What do you think the remaining problem is?  get_from_free_list()
starts out with a not-fully-zeroed object?  Something else?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/