Re: [PATCH 2/2] [RESEND] tracing: Add a new workqueue tracer

[Frederic Weisbecker]

On Mon, Jan 12, 2009 at 03:00:01PM -0500, Steven Rostedt wrote:
> 
> On Mon, 12 Jan 2009, Frederic Weisbecker wrote:
> > > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), 
> > > num_possible_cpus(), for_each_possible_cpu(), etc
> > > #953: FILE: kernel/trace/trace_workqueue.c:153:
> > > +	for (i = 0; i < NR_CPUS; i++) {
> > > 
> > > We should probably change them to for_each_possible_cpu, or online cpu.
> > > 
> > > -- Steve
> > 
> > 
> > I found it very convenient because I didn't have to allocate
> > my cpu list array dynamically with it :-)
> > 
> > I'm preparing a v2...
> >  
> 
> Thanks!
> 
> -- Steve
> 


Here it is:

--