Re: [RFC 0/4] net namespace for PPP

[Alexey Dobriyan]

On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
> here is a series of RFC in attempt to implement
> net-namespaces for PPP protocol (including PPPoE
> and PPPoL2TP).

You need assign netns to netdevice after alloc_netdev().
This should fix much confusion and non-bugs mentioned in this thread.

After that struct ppp shouldn't need netns pointer as it will be netns
of it's netdevice.

current->nsproxy->net_ns while being correct in ioctl context
(it's synchronous) is easy to screwup. For example, in netfilter code netns
is taken from socket on which ioctl is done.

Regardless of netns, try_module_get() calls by hand are suspicious
and they're copied to netns init hook.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/