Re: [Bug #12422] 2.6.28-git can't resume from str

[Ingo Molnar]

* Jeff Chua <jeff.chua.linux@xxxxxxxxx> wrote:

> On Mon, Jan 12, 2009 at 12:39 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> > * Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote
> >> I guess Jeff, meant the other way around.
> >> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
> >> problem , the earlier patch (before) does of course not work.
> > ah, okay.
> > So i suspect that at every bisection point, this should be done:
> >  git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388
> 
> I started with the latest git, and did this ...
> 
> git bisect start
> git bisect bad
> git bisect good a0e280e0f33f6c859a235fb69a875ed8f3420388
> 
> Everything in-between should have
> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?

not necessarily - if an intermediate tree that is checked happened to have 
been based on some earlier -rc, it might have that bug included. Safest is 
to always cherry-pick that commit. (if it has no dependencies)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/