Re: Build error on latest git

From: Jaswinder Singh Rajput
Date: Sun Jan 11 2009 - 08:06:43 EST


On Sun, Jan 11, 2009 at 5:27 PM, Petr Titera <P.Titera@xxxxxxxxxx> wrote:
> Going through source it seems to me (still building) that it is caused by
> including asm/smp.h only if build with CONFIG_SMP. This patch seems to fix
> this
>
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index b824669..fd51bb9 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -11,6 +11,8 @@
> #include <linux/list.h>
> #include <linux/cpumask.h>
>
> +#include <asm/smp.h>
> +
> extern void cpu_idle(void);
>

No, this is wrong.

asm/smp.h should only be included when CONFIG_SMP is defined.

I will send fix of this.

--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/