Re: [PATCH] sata_sil: add Large Block Transfer support

From: Alan Cox
Date: Tue Dec 23 2008 - 05:10:37 EST


> > We know the register's always MMIO on this controller, so it's slightly
> > more optimal to avoid the conditional in there.
>
> Yeah, by a small margin but I think the consensus was to use
> ioread/write no matter what if it's mapped using iomap. I don't think
> we guarantee iomapped address == mmio address after all.

This was discussed before - using writel/readl on iomap is wrong. It may
happen to work on some platforms but shouldn't be expected to work on all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/