Re: [PATCH] sh: maple: add support for Maple controller as ajoystick

[Rabin Vincent]

On Fri, Dec 19, 2008 at 11:15:42PM +0000, Adrian McMenamin wrote:
> Add support for the SEGA Dreamcast Maple controller as a joystick

[snip]

> +
> +	pad = kzalloc(sizeof(struct dc_pad), GFP_KERNEL);
> +	idev = input_allocate_device();
> +	if (!pad || !idev){
> +		error = ENOMEM;
> +		goto fail;
> +	}
> +

[snip]

> +
> +	error = input_register_device(idev);
> +	if (error)
> +		goto fail;
> +
> +	mdev->driver = mdrv;
> +	maple_set_drvdata(mdev, pad);
> +
> +	return error;
> +
> +fail:
> +	input_free_device(pad->dev);
> +	kfree(pad);
> +	maple_set_drvdata(mdev, NULL);
> +	return -error;
> +}

This will incorrectly negate the already negative error code from
input_register_device.

Rabin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/