Re: [PATCH 11/14] kmemleak: Remove some of the kmemleak false positives

From: Pekka Enberg
Date: Fri Dec 19 2008 - 15:15:27 EST


On Fri, Dec 19, 2008 at 8:13 PM, Catalin Marinas
<catalin.marinas@xxxxxxx> wrote:
> There are allocations for which the main pointer cannot be found but
> they are not memory leaks. This patch fixes some of them. For more
> information on false positives, see Documentation/kmemleak.txt.
>
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>

> @@ -2882,6 +2883,12 @@ static int __init con_init(void)
> */
> for (currcons = 0; currcons < MIN_NR_CONSOLES; currcons++) {
> vc_cons[currcons].d = vc = alloc_bootmem(sizeof(struct vc_data));
> + /*
> + * Kmemleak does not track the memory allocated via
> + * alloc_bootmem() but this block contains pointers to
> + * other blocks allocated via kmalloc.
> + */
> + kmemleak_alloc(vc, sizeof(struct vc_data), 1, GFP_ATOMIC);
> INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
> visual_init(vc, currcons, 1);
> vc->vc_screenbuf = (unsigned short *)alloc_bootmem(vc->vc_screenbuf_size);

I think there was some discussion about adding hooks to the bootmem
allocator. Didn't that work out?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/