Re: TSC not updating after resume: Bug or Feature?

From: Rafael J. Wysocki
Date: Thu Dec 18 2008 - 17:20:42 EST


On Thursday, 18 of December 2008, Ingo Molnar wrote:
>
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > Rafael, would something like this explain why we had to revert Shaggy's
> > patch?

Well, I have yet to understand what the suspend-resume of the timekeeping code
actually does.

The original description sounds worrisome to me, it looks like we've overlooked
something at least.

> > His patch fixes the backward motion filter and I'm at an utter
> > loss why that would break suspend.
>
> yes, i'd love to have this commit reinstated:
>
> 5b7dba4: sched_clock: prevent scd->clock from moving backwards
>
> and the bug triggered by hibernation fixed instead.

Shaggy said he had an idea of what was wrong, so I expect an updated version
of the patch to appear.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/