Re: nbd: clean up error handling

[Paul Clements]

Hi Pavel,

hanks for the patch...

Pavel Machek wrote:
> Uses existing error_out: label instead of hardcoding error action.
>
> Signed-off-by: Pavel Machek <pavel@xxxxxxx>

> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
>  	if (nbd_send_req(lo, req) != 0) {
>  		printk(KERN_ERR "%s: Request send failed\n",
>  				lo->disk->disk_name);
> -		req->errors++;
> -		nbd_end_request(req);
> +		goto error_out;

This one is not correct. We don't return immediately here.


--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/