Re: [PATCH/RFC 2/8] crypto: compress - Add pcomp interface

[Geert Uytterhoeven]

On Thu, 18 Dec 2008, Herbert Xu wrote:
> On Wed, Dec 17, 2008 at 05:36:37PM +0100, Geert Uytterhoeven wrote:
> > @@ -3,7 +3,7 @@
> >  #
> >  
> >  obj-$(CONFIG_CRYPTO) += crypto.o
> > -crypto-objs := api.o cipher.o digest.o compress.o
> > +crypto-objs := api.o cipher.o digest.o compress.o pcompress.o
> 
> Sorry, you modelled it on the wrong type.  These are the original
> and obsolete types.  You should model it on one of the others.  I
> recommend the crypto_shash type which is most recent.

Can you please elaborate a bit more?

You mean pcomp should provide a struct crypto_type?
And the underlying algorithms shouldn't use crypto_alg directly anymore?

Thanks!

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village  Da Vincilaan 7-D1  B-1935 Zaventem  Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven@xxxxxxxxxxx
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 Â RPR Brussels
Fortis  BIC GEBABEBB  IBAN BE41293037680010
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/