Re: [patch] x86: convert rdtscll() to use __native_read_tsc

From: Ingo Molnar
Date: Thu Dec 18 2008 - 08:31:57 EST



* Ken Chen <kenchen@xxxxxxxxxx> wrote:

> On Tue, Dec 16, 2008 at 2:15 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> > agreed mostly, with this twist: vdso inlining dependencies should be
> > expressed explicitly, via:
> >
> > native_vread_tsc()
> >
> > but we can also make native_read_tsc() __always_inline [it's a single
> > instruction with basically no preparatory halo around that instruction]
> > and document the vdso detail there.
>
> Given that vdso already uses the inline version of __native_read_tsc, we
> don't really have churn all that code around. I also take your analysis
> as there is no issue in converting rdtscll() to __native_read_tsc().
> Would it be possible for you to merge the patch then?

yep, i already did that when i replied to your mail, it's in tip/x86/time.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/