Re: [PATCH] Allow HPET force enable on ICH10 HPET

From: Pavel Machek
Date: Thu Dec 18 2008 - 02:49:39 EST


On Tue 2008-12-16 02:35:47, Andi Kleen wrote:
> Allow HPET force enable on ICH10 HPET
>
> Intel "Smackover" x58 BIOS don't have HPET enabled in the BIOS, so allow
> to force enable it at least. The register layout is the same
> as in other recent ICHs, so all the code can be reused.
>
> Using numerical PCI-ID because it's unlikely the PCI-ID will be used
> anywhere else.
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Why not fix it properly... in the BIOS?

> @@ -170,7 +170,8 @@
> ich_force_enable_hpet);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_7,
> ich_force_enable_hpet);
> -
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x3a16, /* ICH10 */
> + ich_force_enable_hpet);
>
> static struct pci_dev *cached_dev;


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/