Re: [PATCH 5/7] power_supply: PCF50633 battery charger driver

[Balaji Rao]

On Tue, Dec 16, 2008 at 01:38:11AM +0300, Anton Vorontsov wrote:
> Hello Balaji,
> 
> It's great to see OpenMoko patches submitted, much thanks
> for your work!
> 

Hi Anton,

You are welcome!

> > +
> > +	/* Set up IRQ handlers */
> > +	for (i = 0; i < ARRAY_SIZE(mbc_irq_handlers); i++)
> > +		pcf->irq_handler[mbc_irq_handlers[i]] =
> > +					pcf50633_mbc_irq_handler;
> 
> Ugh. Is there any particular reason why you don't implement a
> chained interrupt controller in the PCF core? (as in
> drivers/mfd/asic3.c, for example).
> 
> That way you could do ordinary request_irq() for the MFD devices'
> interrupts.
> 
> (I can only guess: you didn't make it because PCF is on the
> I2C bus, and it's just easier to handle devices via single
> workqueue in the core driver?)
> 

Since we have a fixed number of irq consumers, it's much simpler doing
chained interrupts this way. Using an irq_chip is going to introduce
unnecessary complezity, I feel.

The V2, of the series (about to be sent) changes how irq managemt
is done - pcf50633_request_irq and pcf50633_free_irq are used.

Thank you for the review.

Will send a new version soon.

	- Balaji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/