Re: [RFC] x86: entry_64 - introduce FTRACE_ frame macro

From: Frédéric Weisbecker
Date: Sat Dec 13 2008 - 09:46:35 EST


2008/12/13 Cyrill Gorcunov <gorcunov@xxxxxxxxx>:
> [Steven Rostedt - Fri, Dec 12, 2008 at 04:56:47PM -0500]
> ...
> | > Steve, here is how it could look like:
> | > (I liked first proposal more :)
> |
> | I see the confusion. In ftrace.h the function graph tracer config is not
> | inside CONFIG_FUNCTION_TRACER, even though it is dependent on it (or
> | was). OK, just do your first proposal then.
> |
> | -- Steve
> |
>
> ok, I sent it yesterday as
>
> http://lkml.org/lkml/2008/12/12/301
> [PATCH] x86: entry_64 - introduce FTRACE_ frame macro v2
>
> Ingo, will you pick it up?
>
> - Cyrill -
>

Hi,

Looks good and clarify the asm bits.

I wonder if the function_graph_tracer should continue to necessarily
depend on the function tracer.
It was more simplier to do so but perhaps that could be avoided with
small modifications.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/