Re: [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl

From: Andi Kleen
Date: Fri Dec 12 2008 - 08:47:47 EST


Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx> writes:

> The current memory copy function of nilfs2 ioctl has following
> problems:

Wouldn't it be easier/faster/more reliable to just use vmalloc for
those allocations? The only reason to use kmalloc for such large
allocations would be if you want to do direct DMA (but even there are
ways to do this using virtual allocations and scatter-gather)

-Andi
>

--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/