Re: [PATCH] nohz: no softirq pending warnings for offline cpus

From: Ingo Molnar
Date: Fri Dec 12 2008 - 01:27:53 EST



* Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:

> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> After a cpu was taken down during cpu hotplug (read: disabled for interrupts)
> it still might have pending softirqs. However take_cpu_down makes sure
> that the idle task will run next instead of ksoftirqd on the taken down cpu.
> The idle task will call tick_nohz_stop_sched_tick which might warn about
> pending softirqs just before the cpu kills itself completely.
> However the pending softirqs on the dead cpu aren't a problem because they
> will be moved to an online cpu during CPU_DEAD handling.
>
> So make sure we warn only for online cpus.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> kernel/time/tick-sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to tip/timers/nohz, thanks Heiko!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/