Re: [PATCH 2/2 v2] ATA: piix, fix pointer deref on suspend

From: Andrew Morton
Date: Thu Dec 11 2008 - 15:28:49 EST


On Tue, 9 Dec 2008 21:52:28 +0100
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> Commit
> ata_piix: add borked Tecra M4 to broken suspend list
> introduced DMI variables checking, but they can be null, so that
> we possibly dereference null.
>
> Check if they are null and avoid checks in that case.
>
> Solves:
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230

This already got fixed, the nasty way.

I queued "DMI: add dmi_match". We can later switch the piix nastyfix
over to the nicefix as a cleanup.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/