Re: [PATCH] memory hotplug: run lru_add_drain_all() on each cpu

[KOSAKI Motohiro]

CC to Lee Schermerhorn


> On Fri, 2008-12-05 at 14:08 +0100, Gerald Schaefer wrote:
> > 
> > As explained above, the per-cpu pagevec layout should be independent
> > from NUMA or UNEVICTABLE_LRU, so I guess the right thing to do here
> > is completely remove the #ifdef as in the patch from Kosaki Motohiro
> > (or at least replace it with a CONFIG_SMP as suggested by Kamezawa
> > Hiroyuki).
> 
> Thanks for looking into it deeper.  That CONFIG_SMP thing really does
> look like the right solution.

Lee, Could you read this thread and explain why you add ifdef CONFIG_UNEVICTABLE_LRU?
I am not sure about that Dave's proposal is safe change. (but I guess he is right)




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/