Re: [RFC 5/8] param: arch_get_boot_command_line() (take II)

[Russell King]

On Thu, Dec 04, 2008 at 11:28:32AM +1030, Rusty Russell wrote:
> On Thursday 04 December 2008 05:07:25 Luck, Tony wrote:
> > > I pulled your git tree.  All my test configs build cleanly
> > > for ia64 ... but sadly the first kernel I tested (generic_defconfig)
> > > doesn't boot (no console output at all).
> > >
> > > I'll see if I can figure out what is going on.
> >
> > Aha.
> 
> OK, both appended to git tree.  
> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-boot-params.git
> 
> If noone else complains, I'll fold the fix and ask Stephen to take the tree 
> for linux-next.

One commit in there looks rather dirty:

| commit c3f789e6270db86717ef578fa2383ca59b134108
| Author: Tony Luck <tony.luck@xxxxxxxxx>
| Date:   Thu Dec 4 11:06:18 2008 +1030
| 
|     Aha.  You are now calling machvec_init_from_cmdline() too early (before
|     efi_init() and io_port_init()) ... so we croak accessing things
|     that have not been set up.  Naive fix is to just move them from
|     setup_arch() to arch_get_boot_command_line().  I can't see how to
|     handle this more cleanly given that you do the rest of the
|     command line parsing before calling setup_arch().
| 
|     With the addition of this patch ia64 bits are
| 
|     Acked-by: Tony Luck <tony.luck@xxxxxxxxx>

I'm wondering whether the ia64 bits are now green, yellow or maybe they're
taking some terminal exercise by jumping off the cliff like lemmings.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/