Re: [PATCH 2/3] fix warning of not used variable

From: AmÃrico Wang
Date: Fri Dec 05 2008 - 19:53:15 EST


On Fri, Dec 5, 2008 at 12:01 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> On Thursday 04 December 2008 22:06:33 AmÃrico Wang wrote:
>> On Thu, Dec 4, 2008 at 1:00 AM, Jianjun Kong <jianjun@xxxxxxxxx> wrote:
>> > fix this warning:
>> > kernel/module.c:824: warning: 'print_unload_info' defined but not used
>> > print_unload_info() just used when CONFIG_PROC_FS was defined.
>> >
>> > Signed-off-by: Jianjun Kong <jianjun@xxxxxxxxx>
>>
>> Reviewed-by: WANG Cong <wangcong@xxxxxxxxx>
>
> My main concern is that this adds two new #ifdef sections. How about marking
> both cases "inline" instead?
>

Hi, sorry for the delay.

Er, making them inline can solve this problem?
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i