Re: [PATCH 2/3] tracing/ftrace: fix the check of ftrace_trace_task

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> On Thu, 4 Dec 2008, Frederic Weisbecker wrote:
> 
> > Impact: fix default empty traces on function-graph-tracer
> > 
> > The actual ftrace_trace_task() checks if ftrace_pid_trace is 
> > allocated and return 1 if it is true. If it is NULL, it will check 
> > the bit of pid tracing flag for the current task (which are not set 
> > by default). So by default, a task is not traced. Actually all tasks 
> > should be traced by default and filter_by_pid when ftrace_pid_trace 
> > is allocated.
> 
> Heh, I thought my output look funny. The function tracer does not use 
> it since it registers a different function. But because the graph 
> tracer only shows the current task on switch (I did not look into trace 
> options) I could not really test it well.
> 
> -- Steve
> 
> Acked-by: Steven Rostedt <srostedt@xxxxxxxxxx>

applied to tip/tracing/ftrace, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/