Re: [patch 011/104] fbdev: clean the penguins dirty feet

[Pavel Machek]

On Wed 2008-12-03 11:48:38, Greg KH wrote:
> 2.6.27-stable review patch.  If anyone has any objections, please let us know.
> 
> ------------------
> From: Clemens Ladisch <clemens@xxxxxxxxxx>
> 
> commit cf7ee554f3a324e98181b0ea249d9d5be3a0acb8 upstream.
> 
> When booting in a direct color mode, the penguin has dirty feet, i.e.,
> some pixels have the wrong color.  This is caused by
> fb_set_logo_directpalette() which does not initialize the last 32 palette
> entries.

Heh, funny, but... is this really bad enough bug to go to stable?

									Pavel

> Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Krzysztof Helt <krzysztof.h1@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> ---
>  drivers/video/fbmem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -232,7 +232,7 @@ static void fb_set_logo_directpalette(st
>  	greenshift = info->var.green.offset;
>  	blueshift = info->var.blue.offset;
>  
> -	for (i = 32; i < logo->clutsize; i++)
> +	for (i = 32; i < 32 + logo->clutsize; i++)
>  		palette[i] = i << redshift | i << greenshift | i << blueshift;
>  }
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/