Re: [PATCH] Use vprintk rather that vsnprintf where possible

[Nick Andrew]

On Fri, Dec 05, 2008 at 04:05:06AM +0100, Kay Sievers wrote:
> On Thu, Dec 4, 2008 at 21:41, Matt Mackall <mpm@xxxxxxxxxxx> wrote:
> > This does away with lots of large static and on-stack buffers as well
> > as a few associated locks.
> 
> > -               len = snprintf(s, 256, KERN_DEBUG "%s: ", prefix);
> > -
> >                va_start(args, fmt);
> > -               len += vsnprintf(&s[len], (256 - len), fmt, args);
> > +               printk(KERN_DEBUG "%s: ", prefix);
> > +               vprintk(fmt, args);
> 
> If we convert to two printk calls for a single line, does that not
> possibly get mixed up with printks from other locations and lead to
> hardly readable log output?

That's right.

Nick.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/