Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG

[Cornelia Huck]

On Wed, 3 Dec 2008 15:12:03 -0500,
Jason Baron <jbaron@xxxxxxxxxx> wrote:

> indeed. you raise the more general question of what do if both 'DEBUG'
> and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
> general the 'DEBUG' should take precedence, as you point out. However, I
> think we should fix this by reshuffling the logic in
> include/linux/kernel.h by doing:
> 
> if (DEBUG)
> 	#define pr_debug printk
> elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
> 	#define pr_debug dynamic_pr_debug()
> else
> 	#define pr_debug if (0) blah:
> endif
> 
> make sense? what do you think?

Yes, that makes sense, I agree. I'll follow up with a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/