Re: [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch

[KAMEZAWA Hiroyuki]

Daisuke Nishimura said:
> On Wed, 3 Dec 2008 14:14:23 +0900, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
>> Implement hierarchy reclaim by cgroup_id.

>> +	rcu_read_lock();
>> +	if (!root_mem->use_hierarchy) {
>> +		spin_lock(&root_mem->reclaim_param_lock);
>> +		root_mem->scan_age++;
>> +		spin_unlock(&root_mem->reclaim_param_lock);
>> +		css_get(&root_mem->css);
>> +		goto out;
>>  	}
>>
> I think you forgot "ret = root_mem".
> I got NULL pointer dereference BUG in my test(I've not tested
> use_hierarchy case yet).
>
yes...thank you for catching. will fix.

-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/