Re: [PATCH 2/3] fix warning of not used variable

[Ingo Molnar]

* Jianjun Kong <jianjun@xxxxxxxxx> wrote:

> 
> fix this warning:
> kernel/module.c:824: warning: âprint_unload_infoâ defined but not used
> print_unload_info() just used when CONFIG_PROC_FS was defined.
> 
> Signed-off-by: Jianjun Kong <jianjun@xxxxxxxxx>
> ---
>  kernel/module.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

NAK. Warnings do not need to be "fixed", then need to be looked at and 
then there are two approaches:

 1) GCC is wrong => annotate the code
 2) GCC is right => fix the code

Your patch does not give us any idea about which case this is, whether 
you have analyzed the reason why GCC emitted that warning.

Besides, i dont see such warnings in kernel/module.c with latest GCC.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/