m68k 8390 breakage (was: Re: linux-next: Tree for December 3)

From: Geert Uytterhoeven
Date: Wed Dec 03 2008 - 14:49:57 EST


On Wed, 3 Dec 2008, Stephen Rothwell wrote:
> Status of my local build tests will be at
> http://kisskb.ellerman.id.au/linux-next . If maintainers want to give
> advice about cross compilers/configs that work, we are always open to add
> more builds.

Since a few days, m68k defconfig and allmodconfig give:

| drivers/net/lib8390.c:1014: undefined reference to `ei_start_xmit'
| drivers/net/lib8390.c:1015: undefined reference to `ei_get_stats'
| drivers/net/lib8390.c:1016: undefined reference to `ei_set_multicast_list'

(cfr. e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/58795/)

git bisect run on "make ARCH=m68k mac_defconfig vmlinux" tells me:

8884c092e5e4f9a1b6e44f2e02a3eb5481af87ab is first bad commit
commit 8884c092e5e4f9a1b6e44f2e02a3eb5481af87ab
Author: Stephen Hemminger <shemminger@xxxxxxxxxx>
Date: Tue Nov 25 18:12:49 2008 -0800

8390: add common net_device ops

Fix the defactoring of ei_XXX functions in 8390 and 8390p.
Remove the tx_timeout hack since no driver including the 3c503
overrides tx_timeout at this time, looks like a legacy thing.

Also, since several drivers all have same hooks, provide common
netdev_ops.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/