Re: [PATCH 2/2] tracing/function-graph-tracer: improve durationoutput

From: Steven Rostedt
Date: Wed Dec 03 2008 - 08:21:41 EST



On Wed, 3 Dec 2008, Fr?d?ric Weisbecker wrote:
>
>
> I proposed a solution for ftrace_printk (which I planned to implement
> this evening).
> Since we are in a C-style output, that would be good to put the ftrace_printk
> as /* C comments */ inside just below the function that called it.
> Like this:
>
> func_that_called_ftrace_printk {
> /* Message from ftrace_printk */
> }
>
> This way we keep the idea of comment which comes along the role of
> ftrace_printk and we know
> which function called it, at which depth.....
>
> Do you like it this way?

Yes definitely. I thought we already decided to do it that way ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/