Re: [PATCH 3/3] cgroups: introduce link_css_set() to remove duplicate code

[Paul Menage]

On Mon, Dec 1, 2008 at 7:18 PM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
>
> How about:
>
> /**
>  * link_css_set - a helper function to link a css_set to a cgroup
>  * @ tmp_cg_links: cg_cgroup_link objects allocated by allocate_cg_links()
>  * @ cg: the css_set to be linked
>  * @ cgrp: the destination cgroup
>  */

Sounds good.

>
> Because we are linking all the css_sets to the root cgroup, so I think root_cgrp
> helps readability.
>

But we're creating the hierarchy at this point, so there can clearly
only be one cgroup any (which is the root cgroup).

I don't think it's any more or less readable, it just seems an
unnecessary change.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/