Re: [PATCH 3/4] add ksm kernel shared memory driver.

[Jonathan Corbet]

On Tue, 2 Dec 2008 13:24:11 -0800
Chris Wright <chrisw@xxxxxxxxxx> wrote:

> > Using current known techniques. A random collision is just as bad
> > news.  
> 
> And, just to clarify, your concern would extend to any digest based
> comparison?  Or are you specifically concerned about sha1?

Wouldn't this issue just go away if the code simply compared the full
pages, rather than skipping the hashed 128 bytes at the beginning?
Given the cost of this whole operation (which, it seems, can involve
copying one of the pages before testing for equality), skipping the
comparison of 128 bytes seems like a bit of a premature optimization.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/