Re: [ltt-dev] [PATCH] Poll : introduce poll_wait_exclusive() new function

From: KOSAKI Motohiro
Date: Mon Dec 01 2008 - 23:45:21 EST


> > Any thought ?
>
> That looks fine, but before waving the Thundering Herd flag some
> performance numbers should be given IMO, considerng also that this is a
> rather particular use of the poll subsystem.
> Eventually, isn't something like the patch below better than adding custom
> case names to poll_wait() ALA poll_wait_LONGNAMESFOLLOW()?
> That way you can pass your own queueing function:
>
> poll_wait_qfunc(file, head, pt, add_wait_queue_exclusive);

make sense.
I don't found any bug in your patch.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>


Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/