Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH1/3)

[Daniel Mierswa]

This is a multi-part message in MIME format.Split patches as requested in "[PATCH] Fujitsu Amilo PA 1510 key-release
events quirk"
Here's the first out of 3.


On 30.11.2008 08:38, Andrew Morton wrote:
> Please don't send more than one patch per email.  I shall comment on
> the two patches in two separate replies.
>   
done, except that they are three now :)


On 30.11.2008 08:38, Andrew Morton wrote:
> Please also cc linux-input@xxxxxxxxxxxxxxx on input-related patches.
>
>   
done


On 30.11.2008 08:38, Andrew Morton wrote:
> oh my.  Please, no.  Just write a C function:
>
> void atkbd_gen_release_event(unsigned int *keys, unsigned nr_keys)
> {
> 	...
> }
>
>   
done, I prefer that myself, although I first thought it might be a bad
idea to pass around pointers there, since
other developers might expect ARRAY_SIZE to work in gen_release_events.

--
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply 
know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22