Re: [PATCH 2/2] drivers/pci/hotplug: Add missing pci_dev_get

From: Jesse Barnes
Date: Mon Dec 01 2008 - 15:31:00 EST


On Sunday, November 23, 2008 12:08 am Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> pci_get_slot does a pci_dev_get, so pci_dev_put needs to be called in an
> error case.
>
> An alterative would be to move the test_and_set_bit before the call to
> pci_get_slot.
>
> The problem was fixed using the following semantic patch.
> (http://www.emn.fr/x-info/coccinelle/)

Applied to my linux-next branch, thanks. Btw, I've seen quite a few of these
Coccinelle related patches fly by, but I haven't seen an introduction of the
tool posted to lkml. Did I miss it? Or maybe it just went to the janitors
list? If not, it seems like it might be a worthwhile thing to describe for
people...


--
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/