Re: [PATCH] lro: IP fragment checking
From: Andrew Gallatin
Date: Mon Dec 01 2008 - 12:50:42 EST
Jan-Bernd Themann wrote:
This patch prevents that ip fragmented TCP packets are considered vaild
for aggregation
<...>
+ if (iph->frag_off & IP_MF)
+ return -1;
+
I think there is an endian bug, and that you should also check
IP_OFFSET. What about:
if (iph->frag_off & htons(IP_MF|IP_OFFSET))
As to whether or not to do it in the drivers/hardware or in the
LRO code, I favor doing it in the LRO code just so that it is not
missed in some driver.
Drew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/